[v10.x backport] Windows CI job update changes #30726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't exit vcbuild with error code 0 when cctest fails.
nodejs-github-bot
added
build
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@joaocgreis, as a FYI I don't think this will get a green CI until nodejs/build#2072 is resolved |
BethGriggs
approved these changes
Dec 3, 2019
|
@BethGriggs I see there was some progress in the issue, the last CI is green. This, #30725 and #30727 are ready to land, which has to be done by a member of @nodejs/backporters according to the collaborator guide (or please let me know if I should do it). |
|
@joaocgreis I can go through and land all of these |
BethGriggs
pushed a commit
that referenced
this pull request
Dec 3, 2019
Backport-PR-URL: #30726 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 3, 2019
Don't exit vcbuild with error code 0 when cctest fails. Backport-PR-URL: #30726 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in 14e7a35...4d3ec1a |
|
Thanks! |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 16, 2019
Backport-PR-URL: #30726 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Don't exit vcbuild with error code 0 when cctest fails. Backport-PR-URL: #30726 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #30724 to v12. The changes are adapted for v10.
@nodejs/backporters I will update this with any feedback from the original PR. This needs to land soon after to avoid issues running CI.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes